Skip to content

renderdoc: Fix wayland support#419973

Merged
pbsds merged 3 commits intoNixOS:masterfrom
ShyAssassin:renderdoc
Jun 28, 2025
Merged

renderdoc: Fix wayland support#419973
pbsds merged 3 commits intoNixOS:masterfrom
ShyAssassin:renderdoc

Conversation

@ShyAssassin
Copy link
Contributor

This PR fixes renderdoc not launching under wayland due to missing QT plugins
while upstream has marked wayland support as experimental and potentially unsupported i have gone ahead and set QT_QPA_PLATFORMS to wayland;xcb in case that changes in the future

baldurk/renderdoc@f2c1435
https://www.reddit.com/r/gameenginedevs/comments/1in9exd/you_only_realise_what_youve_lost_when_its_gone/

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@ShyAssassin ShyAssassin changed the title Renderdoc: Fix wayland support renderdoc: Fix wayland support Jun 25, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Jun 25, 2025
@nix-owners nix-owners bot requested a review from pbsds June 25, 2025 17:21
@pbsbot
Copy link

pbsbot commented Jun 25, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 419973
Commit: 8594f40f7a67bf3ea0cdca69069f8b7ed27c8a98


x86_64-linux

❌ 4 packages failed to build:
  • renderdoc
  • renderdoc.dev
  • renderdoc.doc
  • shadps4

@pbsds
Copy link
Member

pbsds commented Jun 25, 2025

for some reason it tries to rebuild shiboken2 and fails?

shiboken2> /build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/libshiboken/pep384impl.h:187:24: error: '_PyLong_AsInt' was not declared in this scope; did you mean PyLong_AsInt'?
shiboken2>   187 | #define _PepLong_AsInt _PyLong_AsInt
shiboken2>       |                        ^~~~~~~~~~~~~

@ShyAssassin
Copy link
Contributor Author

That is weird i didnt touch anything that would cause this...
I can build it on my machine with nix build .#renderdoc and the PR CI passed...
running nixpkgs-review pr 419973 myself i get the same error.

I tried rebasing to see if this was an issue with something else getting merged but nix build works and nixpkgs-review still fails.
I have no clue what would cause nix build to build successfully but cause nixpkgs-review to fail

@ShyAssassin
Copy link
Contributor Author

somewhat related maybe?
#417345

@ShyAssassin
Copy link
Contributor Author

ShyAssassin commented Jun 25, 2025

After messing around with nixpkgs-review i am even more confused.
nixpkgs-review pr 419973: Fails
nixpkgs-review rev HEAD: Fails
nixpkgs-review rev HEAD: Forcing python3Packages fails
nixpkgs-review rev HEAD: Forcing python312Packages works

I have no clue what is going on, but i think this is a problem with the tooling (nixpkgs-review) not dealing with the if statement correctly since nix build .#renderdoc and the PR's CI works

@Quince-Pie
Copy link
Contributor

Quince-Pie commented Jun 26, 2025

pythonPackages' = if python3Packages.shiboken2.meta.broken or false then python312Packages else python3Packages;
seems to cause it to build properly.

if lib.meta.availableOn doesn't respect meta.broken, can this instead just use python312Packages?

@Aleksanaa
Copy link
Member

this is a problem with the tooling (nixpkgs-review) not dealing with the if statement correctly

It's impossible. It uses the same Nix on your machine.

When it happens you should check what's on master, because it merges it into master in a worktree before eval.

@Quince-Pie
Copy link
Contributor

Quince-Pie commented Jun 26, 2025

I can reproduce this issue, but I am not sure what the root cause is.

[nix] quince@dragonfly:/t/nixpkgs λ renderdoc nix-build -A renderdoc                                           08:13
/nix/store/ydzhzr53kqjcqpbn1rkrscklqa3lhs9k-renderdoc-1.38
[nix] quince@dragonfly:/t/nixpkgs λ renderdoc nix build .#renderdoc                                            08:13
[nix] quince@dragonfly:/t/nixpkgs λ renderdoc nixpkgs-review rev HEAD                                          08:13
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 31, done.
remote: Counting objects: 100% (29/29), done.
remote: Compressing objects: 100% (12/12), done.
remote: Total 19 (delta 14), reused 9 (delta 5), pack-reused 0 (from 0)
Unpacking objects: 100% (19/19), 2.71 KiB | 252.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
   96861da3c40f..ae655a4e198e  master     -> refs/nixpkgs-review/0
$ git worktree add /home/quince/.cache/nixpkgs-review/rev-84c25ceaac9069eb8b7a3401575945c9cea19075-1/nixpkgs ae655a4e198e87a2984cb092dfe8935f1c5818be
Preparing worktree (detached HEAD ae655a4e198e)
HEAD is now at ae655a4e198e rofi-calc: 2.3.1 -> 2.3.2 (#416452)
Local evaluation for computing rebuilds
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/quince/.cache/nixpkgs-review/rev-84c25ceaac9069eb8b7a3401575945c9cea19075-1/nixpkgs nixpkgs-overlays=/tmp/tmpkubmd00r -qaP --xml --out-path --show-trace --no-allow-import-from-derivation
$ git merge --no-commit --no-ff 84c25ceaac9069eb8b7a3401575945c9cea19075
Automatic merge went well; stopped before committing as requested
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/quince/.cache/nixpkgs-review/rev-84c25ceaac9069eb8b7a3401575945c9cea19075-1/nixpkgs nixpkgs-overlays=/tmp/tmpkubmd00r -qaP --xml --out-path --show-trace --no-allow-import-from-derivation --meta
--------- Impacted packages on 'x86_64-linux' ---------
2 packages updated:
renderdoc shadps4


$ nix build --file /nix/store/xjyi2dsmbmjd5vja9v0zlxkis16nrpi8-nixpkgs-review-3.4.0/lib/python3.12/site-packages/nixpkgs_review/nix/review-shell.nix --nix-path 'nixpkgs=/home/quince/.cache/nixpkgs-review/rev-84c25ceaac9069eb8b7a3401575945c9cea19075-1/nixpkgs nixpkgs-overlays=/tmp/tmpkubmd00r' --extra-experimental-features 'nix-command no-url-literals' --no-link --keep-going --no-allow-import-from-derivation --option build-use-sandbox relaxed --argstr local-system x86_64-linux --argstr nixpkgs-path /home/quince/.cache/nixpkgs-review/rev-84c25ceaac9069eb8b7a3401575945c9cea19075-1/nixpkgs --argstr nixpkgs-config-path /tmp/tmp36scxd7j.nix --argstr attrs-path /home/quince/.cache/nixpkgs-review/rev-84c25ceaac9069eb8b7a3401575945c9cea19075-1/attrs.nix
error: builder for '/nix/store/jsdm6752scc0cq897aw02amrqidsfvfa-shiboken2-5.15.17.drv' failed with exit code 2;
       last 25 log lines:
       > In file included from /nix/store/rdnx32wkaz273f643sv1m1hbd5gh56bz-libxml2-2.14.3-dev/include/libxml2/libxml/tree.h:17,
       >                  from /nix/store/rdnx32wkaz273f643sv1m1hbd5gh56bz-libxml2-2.14.3-dev/include/libxml2/libxml/xpath.h:27,
       >                  from /nix/store/lxc9mlsw66sxhbv2kys59a2c7rx3np9b-libxslt-1.1.43-dev/include/libxslt/xsltutils.h:16,
       >                  from /build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/ApiExtractor/docparser.cpp:41:
       > /nix/store/rdnx32wkaz273f643sv1m1hbd5gh56bz-libxml2-2.14.3-dev/include/libxml2/libxml/parser.h:1106:17: note: declared here
       >  1106 |                 xmlSubstituteEntitiesDefault(int val);
       >       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
       > /build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/ApiExtractor/abstractmetabuilder.cpp: In static member function 'static AbstractMetaType* AbstractMetaBuilderPrivate::translateTypeStatic(const TypeInfo&, AbstractMetaClass*, AbstractMetaBuilderPrivate*, TranslateTypeFlags, QString*)':
       > /build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/ApiExtractor/abstractmetabuilder.cpp:2250:28: warning: possibly dangling reference to a temporary []
       >  2250 |             const QString &arrayElement = typeInfo.arrayElements().at(i);
       >       |                            ^~~~~~~~~~~~
       > /build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/ApiExtractor/abstractmetabuilder.cpp:2250:70: note: the temporary was destroyed at the end of the full expression 'TypeInfo::arrayElements() const().QStringList::QList<QString>.QList<QString>::at(i)'
       >  2250 |             const QString &arrayElement = typeInfo.arrayElements().at(i);
       >       |                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
       > /build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/ApiExtractor/clangparser/compilersupport.cpp:295:16: warning: 'QString clang::compilerFromCMake(const QString&)' defined but not used []
       >   295 | static QString compilerFromCMake(const QString &defaultCompiler)
       >       |                ^~~~~~~~~~~~~~~~~
       > /build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/ApiExtractor/clangparser/clangbuilder.cpp:756:13: warning: 'bool clang::cStringContains(const char*, const char*)' defined but not used []
       >   756 | static bool cStringContains(const char *str, const char *prefix)
       >       |             ^~~~~~~~~~~~~~~
       > make[1]: *** [CMakeFiles/Makefile2:354: libshiboken/CMakeFiles/libshiboken.dir/all] Error 2
       > make[1]: *** Waiting for unfinished jobs....
       > [ 60%] Linking CXX static library libapiextractor.a
       > [ 61%] Built target apiextractor
       > make: *** [Makefile:136: all] Error 2
       For full logs, run:
         nix log /nix/store/jsdm6752scc0cq897aw02amrqidsfvfa-shiboken2-5.15.17.drv
error: 1 dependencies of derivation '/nix/store/k25i7sil3w5pjycwbf6pwlyn62dsgwp2-pyside2-5.15.17.drv' failed to build
error: 2 dependencies of derivation '/nix/store/fbvzwr6434zv5ivhgwmf7m95gb4vx8qr-pyside2-tools-5.15.17.drv' failed to build
error: 3 dependencies of derivation '/nix/store/nfgj9452zqqqymv3h8v38g6k9kk1k3ky-renderdoc-1.38.drv' failed to build
error: 1 dependencies of derivation '/nix/store/bg9pl8hp3h6a6g53l9fk6qh4c9pqpkfs-shadps4-0.9.0.drv' failed to build
error: 2 dependencies of derivation '/nix/store/ryhc413wkjcnyxyqbbzpaybairlxplqx-review-shell.drv' failed to build
--------- Report for 'x86_64-linux' ---------
4 packages built:
renderdoc renderdoc.dev renderdoc.doc shadps4

Logs can be found under:
/home/quince/.cache/nixpkgs-review/rev-84c25ceaac9069eb8b7a3401575945c9cea19075-1/logs


$ /nix/store/clfkfybsfi0ihp7hjkz4dkgphj7yy0l4-nix-2.28.3/bin/nix-shell --argstr local-system x86_64-linux --argstr nixpkgs-path /home/quince/.cache/nixpkgs-review/rev-84c25ceaac9069eb8b7a3401575945c9cea19075-1/nixpkgs --argstr nixpkgs-config-path /tmp/tmp36scxd7j.nix --argstr attrs-path /home/quince/.cache/nixpkgs-review/rev-84c25ceaac9069eb8b7a3401575945c9cea19075-1/attrs.nix --nix-path 'nixpkgs=/home/quince/.cache/nixpkgs-review/rev-84c25ceaac9069eb8b7a3401575945c9cea19075-1/nixpkgs nixpkgs-overlays=/tmp/tmpkubmd00r' /nix/store/xjyi2dsmbmjd5vja9v0zlxkis16nrpi8-nixpkgs-review-3.4.0/lib/python3.12/site-packages/nixpkgs_review/nix/review-shell.nix
these 5 derivations will be built:
  /nix/store/jsdm6752scc0cq897aw02amrqidsfvfa-shiboken2-5.15.17.drv
  /nix/store/k25i7sil3w5pjycwbf6pwlyn62dsgwp2-pyside2-5.15.17.drv
  /nix/store/fbvzwr6434zv5ivhgwmf7m95gb4vx8qr-pyside2-tools-5.15.17.drv
  /nix/store/nfgj9452zqqqymv3h8v38g6k9kk1k3ky-renderdoc-1.38.drv
  /nix/store/bg9pl8hp3h6a6g53l9fk6qh4c9pqpkfs-shadps4-0.9.0.drv
building '/nix/store/jsdm6752scc0cq897aw02amrqidsfvfa-shiboken2-5.15.17.drv'...
Running phase: qmakePrePhase
Running phase: qtPreHook
Running phase: unpackPhase
unpacking source archive /nix/store/fbay1sw5qlxv61zngxvk24rpdxrjpyma-pyside-setup-opensource-src-5.15.17.tar.xz
source root is pyside-setup-opensource-src-5.15.17
setting SOURCE_DATE_EPOCH to timestamp 1747720106 of file "pyside-setup-opensource-src-5.15.17/tools/uic_test.py"
Running phase: patchPhase
applying patch /nix/store/6vpynpmw8n9y4kpwhzfrwf32nnjzl7g5-nix_compile_cflags.patch
patching file sources/shiboken2/ApiExtractor/clangparser/compilersupport.cpp
applying patch /nix/store/sbbyg5hgzcwd7bqbfh1i83wf4nrpmhv7-Final-details-to-enable-3.12-wheel-compatibility.patch
patching file build_scripts/config.py
Hunk #1 succeeded at 137 (offset -1 lines).
applying patch /nix/store/f99zp201pih9j8zfgy5dbw1702fkr5m7-Python-3.12-Fix-the-structure-of-class-property.patch
patching file sources/pyside2/libpyside/feature_select.cpp
applying patch /nix/store/amw7asz9wk6av6qxhnzchm30aai17s3c-Support-running-PySide-on-Python-3.12.patch
patching file build_scripts/config.py
patching file sources/pyside2/PySide2/support/generate_pyi.py
patching file sources/pyside2/libpyside/feature_select.cpp
patching file sources/pyside2/libpyside/pysideproperty.cpp
patching file sources/pyside2/libpyside/pysidesignal.cpp
patching file sources/pyside2/tests/QtWidgets/bug_662.py
patching file sources/pyside2/tests/signals/bug_79.py
patching file sources/shiboken2/libshiboken/pep384impl.cpp
patching file sources/shiboken2/libshiboken/pep384impl.h
patching file sources/shiboken2/libshiboken/signature/signature.cpp
patching file sources/shiboken2/libshiboken/signature/signature_helper.cpp
patching file sources/shiboken2/shibokenmodule/files.dir/shibokensupport/signature/errorhandler.py
patching file sources/shiboken2/tests/samplebinding/enum_test.py
applying patch /nix/store/pwz73z1n2nlksyfdb77wdwndj9scrahg-shiboken2-clang-Fix-and-simplify-resolveType-helper.patch
patching file sources/shiboken2/ApiExtractor/clangparser/clangbuilder.cpp
applying patch /nix/store/cq8ii14c8sbhgbxjdkhnansvinwcg2l4-shiboken2-clang-Fix-build-with-clang-16.patch
patching file sources/shiboken2/ApiExtractor/clangparser/clangbuilder.cpp
Hunk #1 succeeded at 529 (offset 5 lines).
patching file sources/shiboken2/ApiExtractor/clangparser/clangutils.cpp
patching file sources/shiboken2/ApiExtractor/clangparser/clangutils.h
patching file sources/shiboken2/ApiExtractor/tests/testtemplates.cpp
applying patch /nix/store/3vfi6ky6n7d1w2mw88wlg0iqp9yr8v6l-shiboken2-clang-Fix-clashes-between-type-name-and-enumera.patch
patching file sources/shiboken2/ApiExtractor/abstractmetabuilder.cpp
patching file sources/shiboken2/ApiExtractor/abstractmetabuilder.h
patching file sources/shiboken2/ApiExtractor/typesystem_typedefs.h
applying patch /nix/store/3spbdpmnlxj94maif9wbf3bns8nfaydi-shiboken2-clang-Record-scope-resolution-of-arguments-func.patch
patching file sources/shiboken2/ApiExtractor/clangparser/clangbuilder.cpp
Hunk #1 succeeded at 299 (offset 5 lines).
Hunk #2 succeeded at 1064 (offset 31 lines).
patching file sources/shiboken2/ApiExtractor/clangparser/clangutils.cpp
patching file sources/shiboken2/ApiExtractor/clangparser/clangutils.h
patching file sources/shiboken2/ApiExtractor/parser/codemodel.cpp
patching file sources/shiboken2/ApiExtractor/parser/codemodel.h
applying patch /nix/store/r1c7d5japhy64g2cnc5zkzjjpmisi7kc-shiboken2-clang-Remove-typedef-expansion.patch
patching file sources/shiboken2/ApiExtractor/clangparser/clangbuilder.cpp
Hunk #4 succeeded at 558 (offset 2 lines).
Hunk #5 succeeded at 699 (offset 2 lines).
Hunk #6 succeeded at 1093 (offset 4 lines).
applying patch /nix/store/47v3jv3907pmkg219zw6fbg0nmwlw4da-shiboken2-clang-Suppress-class-scope-look-up-for-paramete.patch
patching file sources/shiboken2/ApiExtractor/abstractmetabuilder.cpp
patching file sources/shiboken2/ApiExtractor/abstractmetabuilder.h
patching file sources/shiboken2/ApiExtractor/abstractmetabuilder_p.h
applying patch /nix/store/h1gzzbnqdchgpsirhfwsrnggpphq1qzn-shiboken2-clang-Write-scope-resolution-for-all-parameters.patch
patching file sources/shiboken2/generator/generator.cpp
applying patch /nix/store/03lx5nbq5hjj3jzpqbc1cwbwsprydapn-dont_ignore_optional_modules.patch
patching file sources/cmake_helpers/helpers.cmake
Hunk #1 succeeded at 168 (offset 29 lines).
applying patch /nix/store/xysg7f127vhkbdnrld1nypl66w4zcpjj-Modify-sendCommand-signatures.patch
patching file sources/pyside2/PySide2/Qt3DCore/typesystem_3dcore.xml
Running phase: updateAutotoolsGnuConfigScriptsPhase
Running phase: configurePhase
fixing cmake files...
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/bkr75s27n2bdv66f7mwyl9f0j2bc1gn9-shiboken2-5.15.17/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/bkr75s27n2bdv66f7mwyl9f0j2bc1gn9-shiboken2-5.15.17/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/bkr75s27n2bdv66f7mwyl9f0j2bc1gn9-shiboken2-5.15.17/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/bkr75s27n2bdv66f7mwyl9f0j2bc1gn9-shiboken2-5.15.17/share/doc/shiboken2 -DCMAKE_INSTALL_INFODIR=/nix/store/bkr75s27n2bdv66f7mwyl9f0j2bc1gn9-shiboken2-5.15.17/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/bkr75s27n2bdv66f7mwyl9f0j2bc1gn9-shiboken2-5.15.17/share/man -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/bkr75s27n2bdv66f7mwyl9f0j2bc1gn9-shiboken2-5.15.17/include -DCMAKE_INSTALL_SBINDIR=/nix/store/bkr75s27n2bdv66f7mwyl9f0j2bc1gn9-shiboken2-5.15.17/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/bkr75s27n2bdv66f7mwyl9f0j2bc1gn9-shiboken2-5.15.17/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/bkr75s27n2bdv66f7mwyl9f0j2bc1gn9-shiboken2-5.15.17/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/pbqah1qk4b5y14fqinr1h8zvhqy71v81-gcc-wrapper-14.3.0/bin/strip -DCMAKE_RANLIB=/nix/store/pbqah1qk4b5y14fqinr1h8zvhqy71v81-gcc-wrapper-14.3.0/bin/ranlib -DCMAKE_AR=/nix/store/pbqah1qk4b5y14fqinr1h8zvhqy71v81-gcc-wrapper-14.3.0/bin/ar -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_INSTALL_PREFIX=/nix/store/bkr75s27n2bdv66f7mwyl9f0j2bc1gn9-shiboken2-5.15.17 -DBUILD_TESTS=OFF
CMake Deprecation Warning at CMakeLists.txt:3 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.


CMake Deprecation Warning at CMakeLists.txt:4 (cmake_policy):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.


-- The C compiler identification is GNU 14.3.0
-- The CXX compiler identification is GNU 14.3.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /nix/store/pbqah1qk4b5y14fqinr1h8zvhqy71v81-gcc-wrapper-14.3.0/bin/gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/pbqah1qk4b5y14fqinr1h8zvhqy71v81-gcc-wrapper-14.3.0/bin/g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Using Qt 5
CMake Warning (dev) at data/shiboken_helpers.cmake:324 (find_package):
  Policy CMP0148 is not set: The FindPythonInterp and FindPythonLibs modules
  are removed.  Run "cmake --help-policy CMP0148" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.

Call Stack (most recent call first):
  CMakeLists.txt:32 (shiboken_find_required_python)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found PythonInterp: /nix/store/8zv94bk7lldsr8zsixyw7cqsv1b58c0z-python3-3.13.4-env/bin/python (found version "3.13.4")
CMake Warning (dev) at data/shiboken_helpers.cmake:325 (find_package):
  Policy CMP0148 is not set: The FindPythonInterp and FindPythonLibs modules
  are removed.  Run "cmake --help-policy CMP0148" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.

Call Stack (most recent call first):
  CMakeLists.txt:32 (shiboken_find_required_python)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found PythonLibs: /nix/store/8zv94bk7lldsr8zsixyw7cqsv1b58c0z-python3-3.13.4-env/lib/libpython3.13.so (found version "3.13.4")
-- PYTHON_ARCH:             64
-- CLANG: /nix/store/naskjm4xrwg8wqy8nmk02q4q2infxdpa-clang-15.0.7, /nix/store/wxshh5qd7x0iyhmlr3mjdg7icxba9y34-clang-15.0.7-lib/lib/libclang.so detected by CLANG_INSTALL_DIR
-- Looking for C++ include clang-c/Index.h
-- Looking for C++ include clang-c/Index.h - found
-- Could NOT find Git (missing: GIT_EXECUTABLE) 
-- PYTHONLIBS_FOUND:       TRUE
-- PYTHON_LIBRARIES:       /nix/store/8zv94bk7lldsr8zsixyw7cqsv1b58c0z-python3-3.13.4-env/lib/libpython3.13.so
-- PYTHON_INCLUDE_DIRS:    /nix/store/8zv94bk7lldsr8zsixyw7cqsv1b58c0z-python3-3.13.4-env/include/python3.13
-- PYTHON_DEBUG_LIBRARIES: 
-- PYTHONINTERP_FOUND:     TRUE
-- PYTHON_EXECUTABLE:      /nix/store/8zv94bk7lldsr8zsixyw7cqsv1b58c0z-python3-3.13.4-env/bin/python
-- PYTHON_VERSION:         3.13.4
-- PYTHON_EXTENSION_SUFFIX: .cpython-313-x86_64-linux-gnu
-- PYTHON_EXTENSION_SUFFIX:      .cpython-313-x86_64-linux-gnu
-- PYTHON_CONFIG_SUFFIX:         .cpython-313-x86_64-linux-gnu
-- PYTHON_SHARED_LIBRARY_SUFFIX: .cpython-313-x86_64-linux-gnu
CMake Deprecation Warning at ApiExtractor/CMakeLists.txt:3 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.


CMake Deprecation Warning at ApiExtractor/CMakeLists.txt:4 (cmake_policy):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.


-- Found LibXml2: /nix/store/izqbxvpsxw8b4r4arhlbkm48s3ghbddg-libxml2-2.14.3/lib/libxml2.so (found suitable version "2.14.3", minimum required is "2.6.32")
-- Found LibXslt: /nix/store/9c2gf0p8m8nls9pkvngp5an2skdwi0pa-libxslt-1.1.43/lib/libxslt.so (found suitable version "1.1.43", minimum required is "1.1.19")
-- PYTHON_NUMPY_LOCATION: 
-- SHIBOKEN_PYTHON_INCLUDE_DIRS computed to value: '/nix/store/8zv94bk7lldsr8zsixyw7cqsv1b58c0z-python3-3.13.4-env/include/python3.13'
-- SHIBOKEN_PYTHON_LIBRARIES computed to value: ''
CMake Deprecation Warning at doc/CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.


CMake Warning at doc/CMakeLists.txt:47 (message):
  sphinx-build - not found! doc target disabled


-- Configuring done (0.6s)
-- Generating done (0.0s)
CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_TESTING
    CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    CMAKE_INSTALL_BINDIR
    CMAKE_INSTALL_DOCDIR
    CMAKE_INSTALL_INCLUDEDIR
    CMAKE_INSTALL_INFODIR
    CMAKE_INSTALL_LIBDIR
    CMAKE_INSTALL_LIBEXECDIR
    CMAKE_INSTALL_LOCALEDIR
    CMAKE_INSTALL_MANDIR
    CMAKE_INSTALL_SBINDIR
    CMAKE_POLICY_DEFAULT_CMP0025


-- Build files have been written to: /build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/build
cmake: enabled parallel building
cmake: enabled parallel installing
Running phase: buildPhase
build flags: -j32 SHELL=/nix/store/00zrahbb32nzawrmv9sjxn36h7qk9vrs-bash-5.2p37/bin/bash
[  1%] Generating embed/signature_bootstrap_inc.h, embed/signature_inc.h
[  1%] Built target apiextractor_autogen_timestamp_deps
[  3%] Automatic MOC for target apiextractor
[  3%] Built target apiextractor_autogen
[  4%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/apiextractor_autogen/mocs_compilation.cpp.o
[  7%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/abstractmetabuilder.cpp.o
[  7%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/fileout.cpp.o
[  9%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/messages.cpp.o
[ 16%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/propertyspec.cpp.o
[ 16%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/apiextractor.cpp.o
[ 16%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/graph.cpp.o
[ 16%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/reporthandler.cpp.o
[ 16%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/abstractmetalang.cpp.o
[ 18%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/sourcelocation.cpp.o
[ 20%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/typeparser.cpp.o
[ 21%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/typesystem.cpp.o
[ 24%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/typesystemparser.cpp.o
[ 24%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/typedatabase.cpp.o
[ 27%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/include.cpp.o
[ 27%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/clangparser/clangparser.cpp.o
[ 29%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/clangparser/compilersupport.cpp.o
[ 30%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/clangparser/clangbuilder.cpp.o
[ 32%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/clangparser/clangdebugutils.cpp.o
[ 33%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/clangparser/clangutils.cpp.o
[ 35%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/parser/enumvalue.cpp.o
[ 36%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/parser/codemodel.cpp.o
[ 40%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/xmlutils.cpp.o
[ 40%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/xmlutils_libxslt.cpp.o
[ 41%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/xmlutils_qt.cpp.o
[ 43%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/docparser.cpp.o
[ 44%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/doxygenparser.cpp.o
[ 46%] Building CXX object ApiExtractor/CMakeFiles/apiextractor.dir/qtdocparser.cpp.o
++++ Current contents of
+ embed/
+     signature_bootstrap.pyc
+     signature_bootstrap_inc.h
+     signature_bootstrap.py
+     signature_inc.h
+     signature.zip
+     shibokensupport/
+         feature.py
+         fix-complaints.py
+         __init__.py
+         __init__.pyc
+         feature.pyc
+         fix-complaints.pyc
+         signature/
+             importhandler.py
+             errorhandler.py
+             importhandler.pyc
+             errorhandler.pyc
+             loader.py
+             __init__.py
+             layout.py
+             parser.py
+             parser.pyc
+             mapping.py
+             __init__.pyc
+             mapping.pyc
+             loader.pyc
+             layout.pyc
+             lib/
+                 tool.pyc
+                 enum_sig.pyc
+                 __init__.py
+                 __init__.pyc
+                 tool.py
+                 enum_sig.py
++++
[ 50%] Building CXX object libshiboken/CMakeFiles/libshiboken.dir/basewrapper.cpp.o
[ 50%] Building CXX object libshiboken/CMakeFiles/libshiboken.dir/debugfreehook.cpp.o
[ 50%] Building CXX object libshiboken/CMakeFiles/libshiboken.dir/helper.cpp.o
[ 52%] Building CXX object libshiboken/CMakeFiles/libshiboken.dir/gilstate.cpp.o
[ 53%] Building CXX object libshiboken/CMakeFiles/libshiboken.dir/sbkarrayconverter.cpp.o
[ 55%] Building CXX object libshiboken/CMakeFiles/libshiboken.dir/sbkconverter.cpp.o
In file included from /build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/libshiboken/sbkpython.h:104,
                 from /build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/libshiboken/sbkarrayconverter.h:43,
                 from /build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/libshiboken/sbkarrayconverter.cpp:40:
/build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/libshiboken/sbkarrayconverter.cpp: In function 'void Shiboken::Conversions::sequenceToCppIntArray(PyObject*, void*)':
/build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/libshiboken/pep384impl.h:187:24: error: '_PyLong_AsInt' was not declared in this scope; did you mean 'PyLong_AsInt'?
  187 | #define _PepLong_AsInt _PyLong_AsInt
      |                        ^~~~~~~~~~~~~
/build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/libshiboken/sbkarrayconverter.cpp:164:29: note: in expansion of macro '_PepLong_AsInt'
  164 |     convertPySequence(pyIn, _PepLong_AsInt, handle->data());
      |                             ^~~~~~~~~~~~~~
/build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/ApiExtractor/docparser.cpp: In constructor 'DocParser::DocParser()':
/build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/ApiExtractor/docparser.cpp:50:33: warning: 'int xmlSubstituteEntitiesDefault(int)' is deprecated []
   50 |     xmlSubstituteEntitiesDefault(1);
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
In file included from /nix/store/rdnx32wkaz273f643sv1m1hbd5gh56bz-libxml2-2.14.3-dev/include/libxml2/libxml/tree.h:17,
                 from /nix/store/rdnx32wkaz273f643sv1m1hbd5gh56bz-libxml2-2.14.3-dev/include/libxml2/libxml/xpath.h:27,
                 from /nix/store/lxc9mlsw66sxhbv2kys59a2c7rx3np9b-libxslt-1.1.43-dev/include/libxslt/xsltutils.h:16,
                 from /build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/ApiExtractor/docparser.cpp:41:
/nix/store/rdnx32wkaz273f643sv1m1hbd5gh56bz-libxml2-2.14.3-dev/include/libxml2/libxml/parser.h:1106:17: note: declared here
 1106 |                 xmlSubstituteEntitiesDefault(int val);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 56%] Building CXX object libshiboken/CMakeFiles/libshiboken.dir/sbkenum.cpp.o
make[2]: *** [libshiboken/CMakeFiles/libshiboken.dir/build.make:155: libshiboken/CMakeFiles/libshiboken.dir/sbkarrayconverter.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/ApiExtractor/clangparser/compilersupport.cpp:295:16: warning: 'QString clang::compilerFromCMake(const QString&)' defined but not used []
  295 | static QString compilerFromCMake(const QString &defaultCompiler)
      |                ^~~~~~~~~~~~~~~~~
/build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/ApiExtractor/abstractmetabuilder.cpp: In static member function 'static AbstractMetaType* AbstractMetaBuilderPrivate::translateTypeStatic(const TypeInfo&, AbstractMetaClass*, AbstractMetaBuilderPrivate*, TranslateTypeFlags, QString*)':
/build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/ApiExtractor/abstractmetabuilder.cpp:2250:28: warning: possibly dangling reference to a temporary []
 2250 |             const QString &arrayElement = typeInfo.arrayElements().at(i);
      |                            ^~~~~~~~~~~~
/build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/ApiExtractor/abstractmetabuilder.cpp:2250:70: note: the temporary was destroyed at the end of the full expression 'TypeInfo::arrayElements() const().QStringList::QList<QString>.QList<QString>::at(i)'
 2250 |             const QString &arrayElement = typeInfo.arrayElements().at(i);
      |                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
/build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/ApiExtractor/clangparser/clangbuilder.cpp:756:13: warning: 'bool clang::cStringContains(const char*, const char*)' defined but not used []
  756 | static bool cStringContains(const char *str, const char *prefix)
      |             ^~~~~~~~~~~~~~~
make[1]: *** [CMakeFiles/Makefile2:354: libshiboken/CMakeFiles/libshiboken.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 58%] Linking CXX static library libapiextractor.a
[ 60%] Built target apiextractor
make: *** [Makefile:136: all] Error 2
error: builder for '/nix/store/jsdm6752scc0cq897aw02amrqidsfvfa-shiboken2-5.15.17.drv' failed with exit code 2;
       last 25 log lines:
       >                  from /build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/ApiExtractor/docparser.cpp:41:
       > /nix/store/rdnx32wkaz273f643sv1m1hbd5gh56bz-libxml2-2.14.3-dev/include/libxml2/libxml/parser.h:1106:17: note: declared here
       >  1106 |                 xmlSubstituteEntitiesDefault(int val);
       >       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
       > [ 56%] Building CXX object libshiboken/CMakeFiles/libshiboken.dir/sbkenum.cpp.o
       > make[2]: *** [libshiboken/CMakeFiles/libshiboken.dir/build.make:155: libshiboken/CMakeFiles/libshiboken.dir/sbkarrayconverter.cpp.o] Error 1
       > make[2]: *** Waiting for unfinished jobs....
       > /build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/ApiExtractor/clangparser/compilersupport.cpp:295:16: warning: 'QString clang::compilerFromCMake(const QString&)' defined but not used []
       >   295 | static QString compilerFromCMake(const QString &defaultCompiler)
       >       |                ^~~~~~~~~~~~~~~~~
       > /build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/ApiExtractor/abstractmetabuilder.cpp: In static member function 'static AbstractMetaType* AbstractMetaBuilderPrivate::translateTypeStatic(const TypeInfo&, AbstractMetaClass*, AbstractMetaBuilderPrivate*, TranslateTypeFlags, QString*)':
       > /build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/ApiExtractor/abstractmetabuilder.cpp:2250:28: warning: possibly dangling reference to a temporary []
       >  2250 |             const QString &arrayElement = typeInfo.arrayElements().at(i);
       >       |                            ^~~~~~~~~~~~
       > /build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/ApiExtractor/abstractmetabuilder.cpp:2250:70: note: the temporary was destroyed at the end of the full expression 'TypeInfo::arrayElements() const().QStringList::QList<QString>.QList<QString>::at(i)'
       >  2250 |             const QString &arrayElement = typeInfo.arrayElements().at(i);
       >       |                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
       > /build/pyside-setup-opensource-src-5.15.17/sources/shiboken2/ApiExtractor/clangparser/clangbuilder.cpp:756:13: warning: 'bool clang::cStringContains(const char*, const char*)' defined but not used []
       >   756 | static bool cStringContains(const char *str, const char *prefix)
       >       |             ^~~~~~~~~~~~~~~
       > make[1]: *** [CMakeFiles/Makefile2:354: libshiboken/CMakeFiles/libshiboken.dir/all] Error 2
       > make[1]: *** Waiting for unfinished jobs....
       > [ 58%] Linking CXX static library libapiextractor.a
       > [ 60%] Built target apiextractor
       > make: *** [Makefile:136: all] Error 2
       For full logs, run:
         nix log /nix/store/jsdm6752scc0cq897aw02amrqidsfvfa-shiboken2-5.15.17.drv
error: 1 dependencies of derivation '/nix/store/nfgj9452zqqqymv3h8v38g6k9kk1k3ky-renderdoc-1.38.drv' failed to build
error: build of '/nix/store/bg9pl8hp3h6a6g53l9fk6qh4c9pqpkfs-shadps4-0.9.0.drv', '/nix/store/nfgj9452zqqqymv3h8v38g6k9kk1k3ky-renderdoc-1.38.drv' failed
$ git worktree remove -f /home/quince/.cache/nixpkgs-review/rev-84c25ceaac9069eb8b7a3401575945c9cea19075-1/nixpkgs

this is after being rebased with master on Thu Jun 26 21:07:04 2025 +0800

commit 2657a2e434d192939d98249abdd733ebec58b478 (upstream/master, master)
Merge: 93eab8d3b525 5ed76df62727
Author: Aleksana <me@aleksana.moe>
Date:   Thu Jun 26 21:07:04 2025 +0800

    breitbandmessung: 3.8.0 -> 3.9.0, update electron, move to by-name (#420158)

Other attempts:

  • pythonPackages' = if python3Packages.shiboken2.meta.broken or false then python312Packages else python3Packages; => succeeds

  • nixpkgs-review pr 419973 => fails

  • nixpkgs-review rev HEAD + python312Packages => succeeds

@pbsds
Copy link
Member

pbsds commented Jun 26, 2025

Then lets just use python312Packages and document it is needed because of shiboken2 👍

@ShyAssassin
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 419973
Commit: 752e52a56f00bff475d3b83c5b5a863ac60afae2


x86_64-linux

✅ 4 packages built:
  • renderdoc
  • renderdoc.dev
  • renderdoc.doc
  • shadps4

@pbsds pbsds merged commit 31795c5 into NixOS:master Jun 28, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants